Re: [whatwg/streams] Refactor writable stream erroring to be centralized (#705)

domenic commented on this pull request.



>    stream._state = 'errored';
   stream._storedError = error;
 
-  WritableStreamRejectPromisesInReactionToError(stream);
+  // TODO: layering violation?
+  ResetQueue(stream._writableStreamController);

Well right now WritableStreamDefaultControllerError does something rather different. I guess there is some collision in conventions for naming abtract ops in this area.

I think it is probably OK to leave as-is for now?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/705#discussion_r107875399

Received on Friday, 24 March 2017 10:40:31 UTC