Re: [w3c/IndexedDB] Use StructuredClone() hook (#137)

domenic approved this pull request.

LGTM with nits. I didn't check the realms precisely because it seemed like you only ever used current which is probably the right choice. I assume the "user agent defined realm" situations are for when you're serializing to disk or similar?

> @@ -36,9 +36,8 @@ spec: html; urlPrefix: https://html.spec.whatwg.org/multipage/
             text: worker; url: worker
     urlPrefix: infrastructure.html
         type: dfn
+            text: structuredclone; url: structuredclone

You should be able to not do this if you use `<a abstract-op>StructuredClone</a>(...)` instead of `[=StructuredClone=](...)`. This will also ensure it shows up in your indices with the correct casing.

> @@ -785,7 +785,7 @@ from a [=/value=]. A <dfn>valid key path</dfn> is one of:
 </aside>
 
 [=/Key path=] values can only be accessed from properties explicitly
-copied by the [=structured clone algorithm=], as well as the
+copied by the [=StructuredClone=], as well as the

remove "the"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/IndexedDB/pull/137#pullrequestreview-17350041

Received on Wednesday, 18 January 2017 23:17:30 UTC