- From: Takeshi Yoshino <notifications@github.com>
- Date: Thu, 05 Jan 2017 22:18:53 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 6 January 2017 06:19:25 UTC
I found that the reference implementation will be readable and easier to maintain if we move the `.catch(() => {})` to the promise fulfilling/rejecting/resetting helper functions ( https://github.com/whatwg/streams/commit/41c46c263eca3c1ce25fceff97dc7f4a24469569 ). I attempted to do this refactoring, but noticed that considering that the purpose of the reference implementation is for checking the correctness of the specification, it might be better to keep `.catch(() => {})` placed right next to each helper function invocation to keep them in sync with the spec text. Thoughts? If you agree, I just do nothing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/607#issuecomment-270840070
Received on Friday, 6 January 2017 06:19:25 UTC