Re: [whatwg/streams] Execute strategySize first in write() (#680)

ricea commented on this pull request.



> @@ -505,16 +505,6 @@ class WritableStreamDefaultWriter {
       return Promise.reject(defaultWriterBrandCheckException('write'));
     }
 
-    const stream = this._ownerWritableStream;

I moved the stream check back into write().

We need to check `state` after strategy.size() returns, since it may have changed. We could additionally check it before, if we wanted to guarantee that size() is only called in the writable state, but there are no tests for that and I didn't consider it important.

I have started thinking of size() as part of the public API. This makes the line between public methods and abstract operations a bit fuzzier.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/680