Re: [whatwg/streams] Execute strategySize first in write() (#680)

ricea commented on this pull request.



> @@ -747,6 +747,21 @@ function WritableStreamDefaultControllerClose(controller) {
   WritableStreamDefaultControllerAdvanceQueueIfNeeded(controller);
 }
 
+function WritableStreamDefaultControllerGetChunkSize(controller, chunk) {

Originally I didn't inline it because it was a controller operation rather than a writer operation.

Afterwards I realised that once we have a ByteController this will become a polymorphic method call. Maybe the "you ain't gonna need it" principle applies, but I'm pretty sure that we will add a byte controller and that this separation will make sense at that time.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/680

Received on Monday, 13 February 2017 10:07:34 UTC