Re: [whatwg/dom] Add event.srcElement as a legacy alias to event.target (#407)

annevk commented on this pull request.

This looks good. I think I'd prefer adding all the Microsoft extensions at the same time, so we have only one bug report per browser (if needed). Landing them quickly one after another seems okay though.

> @@ -570,6 +571,9 @@ algorithm below.
  <dt><code><var>event</var> . {{Event/target}}</code>
  <dd>Returns the object to which <var>event</var> is <a>dispatched</a>.
 
+ <dt><code><var>event</var> . {{Event/srcElement}}</code>
+ <dd>Returns <var>event</var>'s {{Event/target}} attribute value.

No need to add it here since developers can just use target.

> @@ -642,6 +646,9 @@ attributes must return the values they were initialized to. When an
 <a>event</a> is created the attributes must be
 initialized to null.
 
+The <dfn attribute for=Event><code>srcElement</code></dfn>
+attribute must return the {{Event/target}} attribute value.

I'd prefer to define it together with target. So "The target and srcElement attributes must return X".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/407#pullrequestreview-20974779