Re: [heycam/webidl] Define [[OwnPropertyKeys]] of legacy platform objects (#402)

> While I did write this PR to match what implementations are doing

Ah OK, that's great. I thought it might have been just a translation of the previous enumeration section, in which case there was more cause for concern. But if you have validated this roughly matches browsers, then I would be comfortable merging before in-depth tests. @tobie

> Can you point out the update you are referring to?

https://github.com/tc39/ecma262/pull/367

> Is there a specific section in WPT for Web IDL compliance or should I look into adding these tests to the section of the tested interface (e.g. HTMLCollection)?

https://github.com/w3c/web-platform-tests/tree/master/WebIDL, almost always under ecmascript-binding. As you can see from some tests there, we generally pick representative objects. https://github.com/w3c/web-platform-tests/blob/255d54144a82ce76d8e50a4aa8de284151119f8b/WebIDL/ecmascript-binding/legacy-platform-object.html is probably the file to work on, although I think nobody would mind having a separate file for the OwnPropertyKeys sub-cases as that file is so generically named it could grow without bound.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/402#issuecomment-320815070