Re: [heycam/webidl] Define [[OwnPropertyKeys]] of legacy platform objects (#402)

> I am concerned about the extent to which it matches implementations, especially with regard to ordering

While I did write this PR to match what implementations are doing, I would agree that there are a lot of corner cases, like index prop names that are not array index prop names ([2^32, 2^53)), assigning array index prop names to objects that don't support indexed properties (and vice versa), and symbols. To that end I'd definitely agree that there should be tests.

> if they don't map onto the recent ES spec updates which derive enumeration from own property keys

Can you point out the update you are referring to?

> So, we'll need some good tests of the various permutations here to be sure.

Is there a specific section in WPT for Web IDL compliance or should I look into adding these tests to the section of the tested interface (e.g. `HTMLCollection`)?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/402#issuecomment-320804137

Received on Monday, 7 August 2017 23:04:46 UTC