Re: [heycam/webidl] Automatic publication (#401)

tobie commented on this pull request.

Couple of comments and questions. I'm not sure I'm the best person to review travis publishing mechanics. Maybe @domenic can take a look?

Also, will this require @heycam to do anything?

> @@ -9,6 +9,7 @@ Mailing List Archives: https://lists.w3.org/Archives/Public/public-script-coord/
 Repository: heycam/webidl
 !Feedback: <a href="https://github.com/heycam/webidl">GitHub</a> (<a href="https://github.com/heycam/webidl/issues/new">new issue</a>, <a href="https://github.com/heycam/webidl/issues">open issues</a>, <a href="https://www.w3.org/Bugs/Public/buglist.cgi?product=WebAppsWG&amp;component=WebIDL&amp;resolution=---">legacy bug tracker</a>)
 ED: https://heycam.github.io/webidl/
+TR: https://www.w3.org/TR/webidl-2/

Can we have this point to https://www.w3.org/TR/webidl/ instead?

> @@ -62,3 +68,9 @@ git commit -m "Deploy to GitHub Pages: ${SHA}"
 
 # Now that we're all set up, we can push.
 git push $SSH_REPO $TARGET_BRANCH
+
+function TRpush {
+  curl "https://labs.w3.org/echidna/api/request" --data "url=https://heycam.github.io/webidl/echidna.html" --data "decision=https://lists.w3.org/Archives/Public/public-webapps/2014JulSep/0627.html" --data "token=$TOKEN"'

where is `$TOKEN` defined?

> @@ -62,3 +68,9 @@ git commit -m "Deploy to GitHub Pages: ${SHA}"
 
 # Now that we're all set up, we can push.
 git push $SSH_REPO $TARGET_BRANCH
+
+function TRpush {
+  curl "https://labs.w3.org/echidna/api/request" --data "url=https://heycam.github.io/webidl/echidna.html" --data "decision=https://lists.w3.org/Archives/Public/public-webapps/2014JulSep/0627.html" --data "token=$TOKEN"'

That implies keeping https://heycam.github.io/webidl/echidna.html around, right? Isn't there a cleaner option, here? Not a deal breaker, but the fewer things are floating around, the better.

> @@ -6,6 +6,7 @@ env:
   global:
     - ENCRYPTION_LABEL: "de8b5a0f10ef"
     - COMMIT_AUTHOR_EMAIL: "cam@mcc.id.au"
+    - secure: "IagnnmSy+JOF/Dqv25lSabCLeW5Rxh2VV6MJZjZuRhZR+CDTmH+ZdskHmk0TC19DH2bJ4t+LpBYrVjrCBu+6Ow923i3lNTQiVlXNIvTEZyWKcgttiTDjhytby6gE/CyuM1tPEC34IBnTUuWdURBHe7XFMCGQRDUD02troYxv4b1Jvv6+JzYtE90v6WVv0b0LjiNJ0ruftP7btjMypJoN40N5ObqNwIecL5RfJeEZoE01LtdrpxBEPSgPkv3VN+Fscjwpi8IASbeYLy294KDjRO1WOHx6i02DvJPnTLHdS0LUU6vBcLGRcz0+d760LPsExNRyJ4xpehewux0ueSXm2oMnujdWK0v9eUPrsoimzwL69c5yzCCAr+1PMVffOLAH8kcC2lklZ84LTvy3FGchh5SMfoXlgMwWoJSH4bub2yr38TB/skOem6OuO2M2PUdWkzAMRcj24LZhvCNSfkvy86q1ShtUFRG2mKLjmZa6FK0ONVUVeRbEjZ8PALM76g07c+uZcOAGu5A3xKoP2KOe0YR4rS4T++9oW8+svQDF4GiA5KqZiB8Yce6mW9NQ7/LQZpjllQtqiTATryJ3LW2yRzdo7k/Mz+ajHLhhiElKzTreRHTLZ/8YHvcL1wud1bDCAtoTOem/v3mxGHiXD6NvJZF6hz/Gf0guhN1yigHlNFI="

I'm not too sure how this is supposed to work. Is this supposed to turn into `$TOKEN` later on? Or is there some other magic happening I'm not aware of here. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/401#pullrequestreview-54430661

Received on Friday, 4 August 2017 17:50:00 UTC