Re: [whatwg/dom] Abort controller (#437)

annevk commented on this pull request.

We should also update the Abstract to account for this new feature.

> @@ -660,7 +660,7 @@ flags that are all initially unset:
 <ul>
  <li><dfn export for=Event id=stop-propagation-flag>stop propagation flag</dfn>
  <li><dfn export for=Event id=stop-immediate-propagation-flag>stop immediate propagation flag</dfn>
- <li><dfn export for=Event id=canceled-flag>canceled flag</dfn>
+ <li><dfn export for=Event id=canceled-flag>aborted flag</dfn>

This and similar changes to Events will need to be reverted. Simple search & replace is too simple unfortunately.

> +  readonly attribute boolean aborted;
+
+  attribute EventHandler onabort;
+};
+</pre>
+<dl class=domintro>
+ <dt><code><var>signal</var> . </code>{{AbortSignal/aborted}}
+ <dd>Returns true if this {{AbortSignal}} has been aborted, and false otherwise.
+</dl>
+
+Each {{AbortSignal}} has an <dfn for=AbortSignal>aborted flag</dfn> which is unset unless otherwise
+specified.
+
+Each {{AbortSignal}} has <dfn for=AbortSignal>abort callbacks</dfn>, which is an [=ordered set=] of
+algorithms which are to be executed when its [=AbortSignal/aborted flag=] is set. Unless otherwise
+specified, its value is the empty set.

Can we name this something different from callbacks. Callback already has a very specific meaning in IDL.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/437#pullrequestreview-32061222

Received on Tuesday, 11 April 2017 10:01:14 UTC