Re: [whatwg/streams] Don't mandate transform method in TransformStream (#573)

ricea approved this pull request.

lgtm with the nits I mentioned.

Could you file an issue for the testing gap you noticed?

> @@ -77,7 +77,7 @@ exports.PromiseInvokeOrNoop = (O, P, args) => {
   }
 };
 
-exports.PromiseInvokeOrFallbackOrNoop = (O, P1, args1, P2, args2) => {
+exports.PromiseInvokeOrFallback = (O, P1, args1, F, args2) => {

This operation needs a different name to reflect its unique semantics.

How about `PromiseInvokeOrCallFallback` ?

>    const controller = transformStream._transformStreamController;
-  const transformPromise = PromiseInvokeOrNoop(transformStream._transformer,
-                             'transform', [chunk, controller]);
+
+  const transformPromise = PromiseInvokeOrFallback(transformer, 'transform', [chunk, controller],
+                             TransformStreamDefaultTransform, [chunk, controller]);

Indentation here is odd. Indentation in this file doesn't seem particularly consistent, but I would prefer the second line to be indented after the `(` on the first line.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/573#pullrequestreview-6184831