Re: [w3c/manifest] WIP: beforeinstallprompt (#506)

marcoscaceres commented on this pull request.



> @@ -410,6 +463,94 @@ <h3 id="installation-sec">
       </h2>
       <section>
         <h3>
+          <code>BeforeInstallPromptEvent</code>
+        </h3>
+        <pre class="idl">
+enum AppBannerPromptOutcome {
+  "accepted",
+  "dismissed"
+};
+
+[Constructor(DOMString typeArg, optional BeforeInstallPromptEventInit eventInit)]
+interface BeforeInstallPromptEvent : Event {
+    readonly attribute Promise&lt;AppBannerPromptOutcome&gt; userChoice;

>  I wonder if it's too late to change it?

I certainly wouldn't be opposed. I guess we need some telemetry data on usage to change it - and some coordination with existing sites that are using this. 

> I find the fact that this is a promise attribute (as opposed to a function that returns a promise) really weird. I know it's what Chrome does. I wonder if it's too late to change it?

There are lots of these in the platform, FWIW. https://github.com/heycam/webidl/issues/186#issuecomment-253526030


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/506