- From: Adam Rice <notifications@github.com>
- Date: Fri, 14 Oct 2016 00:46:58 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Message-ID: <whatwg/streams/pull/539@github.com>
Not all issues reported by eslint have been fixed:
* eslint cannot load scripts from importScripts, so sees all those
symbols as undefined.
* eslint does not know about 'self'.
* 'Expected to return a value at the end of this method' for sink
methods in recording-streams.js was harmless so not fixed.
* write(chunk) gives an error "'chunk' is defined but never used". Aids
readability so not fixed.
* "'t' is defined but never used" is reported for many tests. t
parameter has been retained for consistency.
* "Arrow function should not return assignment" ignored.
You can view, comment on, or merge this pull request online at:
https://github.com/whatwg/streams/pull/539
-- Commit Summary --
* Lint fixes to new web-platform-tests
-- File Changes --
M reference-implementation/to-upstream-wpts/resources/recording-streams.js (2)
M reference-implementation/to-upstream-wpts/writable-streams/constructor.js (5)
M reference-implementation/to-upstream-wpts/writable-streams/general.js (8)
M reference-implementation/to-upstream-wpts/writable-streams/start.js (8)
M reference-implementation/to-upstream-wpts/writable-streams/write.js (1)
-- Patch Links --
https://github.com/whatwg/streams/pull/539.patch
https://github.com/whatwg/streams/pull/539.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/539
Received on Friday, 14 October 2016 07:47:27 UTC