Re: [heycam/webidl] Add legacy platform objects. (#230)

domenic approved this pull request.

LGTM with a couple nits. \o/

> @@ -8447,8 +8462,8 @@ at most one interface.  The interface [{{PrimaryGlobal}}]
 is declared on, if any, is known as the <dfn id="dfn-primary-global-interface" export>primary global interface</dfn>.
 
 See [[#named-properties-object]],
-[[#getownproperty]] and
-[[#defineownproperty]]
+[[#legacy-platform-object-getownproperty]] and

These two references are no longer relevant, actually, now that globals have been decoupled.

> -        1.  Let |desc| be a newly created [=Property Descriptor=] with no fields.
-        1.  Set |desc|.\[[Value]] to the result of [=converted to an ECMAScript value|converting=]
-            |value| to an ECMAScript value.
-        1.  If |O| implements an interface with a [=named property setter=], then set
-            |desc|.\[[Writable]] to <emu-val>true</emu-val>, otherwise set it to
-            <emu-val>false</emu-val>.
-        1.  If |O| implements an interface with the
-            [{{LegacyUnenumerableNamedProperties}}]
-            [=extended attribute=],
-            then set |desc|.\[[Enumerable]] to <emu-val>false</emu-val>,
-            otherwise set it to <emu-val>true</emu-val>.
-        1.  Set |desc|.\[[Configurable]] to <emu-val>true</emu-val>.
-        1.  Return |desc|.
-    1.  Return [=OrdinaryGetOwnProperty=](|O|, |P|).
-</div>
+Support for [=getters=] is handled by the <a href="#legacy-platform-object-getownproperty">legacy platform object \[[GetOwnProperty]] method</a>,

Probably using Bikeshed `[[#legacy-platform-...]]` syntax would be good here, despite the slightly less informative link titles?

>  
 Note: For {{Window}} objects, it is unobservable whether this is implemented, since the presence of
 the {{WindowProxy}} object ensures that \[[SetPrototypeOf]] is never called on a {{Window}} object
 directly. For other global objects, however, this is necessary.
 
 
-<h4 id="defineownproperty">Platform object \[[DefineOwnProperty]] method</h4>
+<h4 id="legacy-platform-object-defineownproperty" oldids="defineownproperty" algorithm>\[[DefineOwnProperty]]</h4>

This h4 should not have algorithm, I think?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/230#pullrequestreview-8431928