Re: [whatwg/streams] port piping tests to WPT (#603)

domenic commented on this pull request.

The port looks good, thanks.

I think we should have these in separate files. E.g. piping/pipe-through.js for the duck-typed one, and piping/transform-streams.js for the others. That way people who are implementing in a staged manner (e.g. first pipeTo, then pipeThrough, then transform streams) can pass all the tests in a file at once.

As for the disabled test... either way. I guess you'd want to check desired size, instead of enqueue() return values. It might also be good to minimize the number of timers involved as they make things rather fragile.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/603#pullrequestreview-7508351