Re: [whatwg/streams] WPT-ify most of the remaining tape tests (#604)

domenic approved this pull request.

LGTM with nit; did not check the transform stream tests very closely.

> +
+  assert_throws(new TypeError(), () => getter.call(target), getterName + ' should throw a TypeError');
+}
+
+const ws = new WritableStream();
+const writer = ws.getWriter();
+const WritableStreamDefaultWriter = writer.constructor;
+const WriterProto = WritableStreamDefaultWriter.prototype;
+
+test(() => {
+  getterThrows(WriterProto, 'desiredSize', fakeWritableStreamDefaultWriter());
+  getterThrows(WriterProto, 'desiredSize', realReadableStreamDefaultWriter());
+}, 'WritableStreamDefaultWriter.prototype.desiredSize enforces a brand check');
+
+promise_test(t => {
+  const results = [];

I think all your Promise.all tests would be easier to understand if they were just inline, e.g. `return Promise.all([\n...\n...\n]);`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/604#pullrequestreview-7507059