- From: Domenic Denicola <notifications@github.com>
- Date: Mon, 09 May 2016 10:00:37 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc:
- Message-ID: <whatwg/streams/pull/444/c217924062@github.com>
> PromiseInvokeOrNoop in PromiseInvokeOrFallbackOrNoop should be annotated with !, not ?. Good catch, thanks! > ReadableByteStreamControllerRespondInternal in ReadableByteStreamControllerRespondWithNewView is annotated with ? because of possible abrupt in buffer cloning? Yes, exactly. Anything that allocates a buffer (not just transfers it) can throw. > Then, return is better than perform? I'm fine with the current combination but wanna make sure that it's intentional. Good catch; it was inconsistent. I switched them both to "perform." They are basically equivalent in this case, but I think "perform" is clearer since there is no interesting return value to propagate. > CloneArrayBuffer() is taking 4 arguments while even https://tc39.github.io/ecma262/2016/#sec-clonearraybuffer has up to 3 args. What should I look at? https://tc39.github.io/ecma262/#sec-clonearraybuffer is correct. I am trying to fix the cross-linking next to point to the correct latest ES spec. I am currently blocked on https://github.com/bterlson/ecmarkup/issues/91. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/444#issuecomment-217924062
Received on Monday, 9 May 2016 19:27:02 UTC