Re: [fetch] Clarify the hooks into RFC6265 (#221)

> @@ -2909,11 +2919,14 @@ <h3 id="http-network-fetch"><span class="secno">5.6 </span>HTTP-network fetch</h
>   <!-- XXX xref HTTP cache -->
>  
>   <li>
> -  <p>If <var>credentials flag</var> is set and <var>response</var>'s
> -  <a href="#concept-response-header-list" title="concept-response-header-list">header list</a> contains one or more
> -  <a href="#concept-header" title="concept-header">headers</a> <a href="#concept-header-name" title="concept-header-name">named</a>
> -  `<code title="">Set-Cookie</code>`, update the cookies. <a href="#refsCOOKIES">[COOKIES]</a>
> -  <!-- XXX proper hook? -->
> +  <p>If <var>credentials flag</var> is set and the user agent is not configured to block cookies for
> +  <var>httpRequest</var> (see <a href="https://tools.ietf.org/html/rfc6265#section-7">section 7</a> of
> +  <a href="#refsCOOKIES">[COOKIES]</a>), then run the "set-cookie-string" parsing algorithm (see
> +  <a href="https://tools.ietf.org/html/rfc6265#section-5.2">section 5.2</a> of
> +  <a href="#refsCOOKIES">[COOKIES]</a>) on the <a href="#concept-header-value" title="concept-header-value">value</a>
> +  of each <var>header</var> <a href="#concept-header-name" title="concept-header-name">named</a> `<code title="">Set-Cookie</code>`
> +  contained in <var>response</var>'s <a href="#concept-response-header-list" title="concept-response-header-list">header list</a>, and
> +  <var>response</var>'s <a href="#concept-response-url" title="concept-response-url">url</a>.

The algorithm defined in the RFC doesn't seem to take two arguments. It does talk about request-uri [sic] at some point.

This algorithm will also segfault if we ever support putting cookies in synthetic responses. I think we want to point that out in an HTML comment.

---
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/221/files#r53749967