- From: Boris Zbarsky <notifications@github.com>
- Date: Tue, 16 Feb 2016 04:43:14 -0800
- To: heycam/webidl <webidl@noreply.github.com>
- Message-ID: <heycam/webidl/pull/91/r53005058@github.com>
> @@ -11163,10 +11183,8 @@ partial interface Window { > <li>Let <var>desc</var> be a newly created <a>Property Descriptor</a> with no fields.</li> > <li>Set <var>desc</var>.<span class='prop'>[[Value]]</span> to the result of <a class='dfnref' href='#dfn-convert-idl-to-ecmascript-value'>converting</a> > <var>value</var> to an ECMAScript value.</li> > - <li>If the named property is defined to be <a class='dfnref' href='#dfn-unenumerable'>unenumerable</a>, > - then set <var>desc</var>.<span class='prop'>[[Enumerable]]</span> to <span class='esvalue'>false</span>, > - otherwise set it to <span class='esvalue'>true</span>.</li> > - <li>Set <var>desc</var>.<span class='prop'>[[Writable]]</span> to <span class='esvalue'>true</span> and > + <li>Set <var>desc</var>.<span class='prop'>[[Writable]]</span> to <span class='esvalue'>true</span>, This is wrong, I think. Github's broken UI is refusing to show me where this diff is actually applied, but if this is the "Named properties object [[GetOwnProperty]] method" section, as I think it is, that means the `Window` interface in practice, and its properties are currently unenumerable, right? More to the point, you should be using the `[LegacyUnenumerableNamedProperties]` flag from `A` here, I would think. --- Reply to this email directly or view it on GitHub: https://github.com/heycam/webidl/pull/91/files#r53005058
Received on Tuesday, 16 February 2016 12:43:44 UTC