Re: [whatwg/fullscreen] Define fully exit fullscreen in terms of exitFullscreen({ fully: true }) (#65)

foolip commented on this pull request.



> @@ -365,7 +362,9 @@ attribute's getter must run these steps:
    <a lt="unfullscreen a document">unfullscreen <var>descendantDoc</var></a>.
    <!-- cross-process -->
 
-   <li><p>For each <var>exitDoc</var> in <var>exitDocs</var>, in order,
+   <li><p>For each <var>exitDoc</var> in <var>exitDocs</var>, in order: If <var>exitDoc</var> is

Suggestions also welcome here. Would it be better have exitDocs contain only the documents that should fully exit, and then handle the document above separate? (That is currently "If exitDocs’s last document has a browsing context container, append that browsing context container’s node document to exitDocs.")

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/65#pullrequestreview-13297617

Received on Friday, 16 December 2016 09:24:34 UTC