- From: Anne van Kesteren <notifications@github.com>
- Date: Fri, 16 Dec 2016 01:23:46 -0800
- To: whatwg/fullscreen <fullscreen@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 16 December 2016 09:24:18 UTC
annevk commented on this pull request. > @@ -314,8 +314,8 @@ attribute's getter must run these steps: <ol> <li><p>Let <var>promise</var> be a new promise. - <li><p>If <var>doc</var>'s <a>fullscreen element</a> is null, reject <var>promise</var> with a - <code>TypeError</code> exception, and return <var>promise</var>. + <li><p>If <var>doc</var>'s <a>fullscreen element</a> is null, fulfill <var>promise</var> with + undefined, and return <var>promise</var>. Ugh, I see I used "fulfill" in a couple places instead of "resolve". Do you want me to fix those first in a PR? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fullscreen/pull/66
Received on Friday, 16 December 2016 09:24:18 UTC