Re: [w3c/manifest] Add support for 'serviceworkers' member (#507)

jungkees commented on this pull request.



> +          set <var>registration</var>'s <code>type</code>
+          property to be <var>type</var>.
+          </li>
+          <li>If <var>type</var> is <code>undefined</code> abort these steps and
+          return <code>undefined</code>.
+          </li>
+          <li>Let <var>use cache</var> be the result of running the <a>steps
+          for processing the <code>use_cache</code> member of a service worker</a>
+          passing <var>unprocessed registration</var>.
+          </li>
+          <li>If <var>use cache</var> is not <code>undefined</code>,
+          set <var>registration</var>'s <code>use_cache</code>
+          property to be <var>use cache</var>.
+          </li>
+          <li>If <var>use cache</var> is <code>undefined</code> abort these steps
+          and return <code>undefined</code>.

Same as above. I saw you return false when no value is given. It looks good.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/507