- From: Jungkee Song <notifications@github.com>
- Date: Wed, 14 Dec 2016 07:02:51 -0800
- To: w3c/manifest <manifest@noreply.github.com>
- Message-ID: <w3c/manifest/pull/507/review/12924650@github.com>
jungkees commented on this pull request.
> for processing the <code>scope</code> member of a service worker</a>
passing <var>unprocessed registration</var>.
</li>
<li>If <var>scope</var> is not <code>undefined</code>,
set <var>registration</var>'s <code>scope</code>
property to be <var>scope</var>.
</li>
+ <li>Let <var>type</var> be the result of running the <a>steps
+ for processing the <code>type</code> member of a service worker</a>
+ passing <var>unprocessed registration</var>.
+ </li>
+ <li>If <var>type</var> is not <code>undefined</code>
+ set <var>registration</var>'s <code>type</code>
+ property to be <var>type</var>.
+ </li>
+ <li>If <var>type</var> is <code>undefined</code> abort these steps and
+ return <code>undefined</code>.
Understood. I saw you return "classic" when no value is given. It looks good.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/507
Received on Wednesday, 14 December 2016 15:04:11 UTC