Re: [w3c/manifest] Add support for 'serviceworkers' member (#507)

jungkees commented on this pull request.



>                manifest</a>.
               </li>
               <li>If <a>obtaining the manifest</a> results in an error, a user
               agent can, at this point, fall back to using the <a>top-level
               browsing context</a>' <code>Document</code>'s metadata to
               populate an <a>installation process</a>' UI.
               </li>
+              <li>If <a>obtaining the manifest</a> succeeds, and the
+              <var>service worker registration</var> of <a>manifest</a> is not
+              <code>undefined</code>, a user agent can at this point
+              <ul>
+                <li>Invoke <a>Start Register</a> with <var>scope</var> and <var>src</var>
+                members of the <var>service worker registration</var>, a new <var>promise</var>,
+                null, <a>manifest URL</a>, <code>"classic"</code> and <code>False</code>,

For the _client_ param to Start Register, I think the browsing context's Document's relevant settings object should be passed instead of null. The given client is used to queue a task to later to manipulate promise settlement and parse a fetched script resources later.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/507#pullrequestreview-12683837