- From: Nathan Schloss <notifications@github.com>
- Date: Tue, 16 Aug 2016 09:57:55 -0700
- To: slightlyoff/ServiceWorker <ServiceWorker@noreply.github.com>
Received on Tuesday, 16 August 2016 16:58:31 UTC
@jungkees, I think that if you're rejecting the waitUntil promise or throwing somewhere in the waitUntil that the install really should fail. At Facebook, we currently rely on this to ensure that we don't get conflicting versions of the service worker during a Facebook code push, but more generally, I think that something going wrong during SW instillation is a good reason to not finish the install. If you're saving a bunch of stuff to indexedDB as part of your instillation and then it randomly throws during install the average developer is probably not thinking about this use case when building their service worker and likely would just want the install event to happen again later (either the next time the SW tries to update or by registering the SW again). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/slightlyoff/ServiceWorker/issues/896#issuecomment-240166352
Received on Tuesday, 16 August 2016 16:58:31 UTC