- From: Arthur Stolyar <notifications@github.com>
- Date: Tue, 16 Aug 2016 13:22:20 -0700
- To: slightlyoff/ServiceWorker <ServiceWorker@noreply.github.com>
Received on Tuesday, 16 August 2016 20:23:15 UTC
@n8schloss > I think that if you're rejecting the waitUntil promise or throwing somewhere in the waitUntil that the install really should fail. It's not about rejecting passed to `waitUntil()` promise, but about having runtime error / `throw` error in event handler itself (same tick). e.g. this: ```js self.addEventListener('install', (e) => { __UNDEFINED_1_.doSomething(); // this blocks install e.waitUntil(...); __UNDEFINED_2_.doSomething(); // this blocks install }); ``` This is tough question if it should. Personally I think it's should because it isn't a UI event which should just ignore things are continue delivering normal UI to the user. It's rather an important event of the important thing like SW which ideally must have 0 errors, because if they are they could affect whole website, all users, etc. So personally I think that any (uncaught) error in `install`'s event handler should prevent installation. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/slightlyoff/ServiceWorker/issues/896#issuecomment-240225802
Received on Tuesday, 16 August 2016 20:23:15 UTC