Re: [slightlyoff/ServiceWorker] Install algorithm step 14 should clear waiting worker before updating state to redundant (#851)

> @jungkees presumably the register() method's promise is also resolved from some task, right? If that is queued later, and they are on the same queue, there would not be a problem here.

This is presumably true under the assumption that a task is queued for "resolve" step. I haven't explicitly queued a task for that here. I'm wondering if "resolve" from a thread running in parallel implicitly does queue a task or not. (@domenic, can you help?) I presume it does not as it just synchronously invokes ES resolve function: https://www.w3.org/2001/tag/doc/promises-guide#shorthand-manipulating I think I found some similar case in HTML: https://html.spec.whatwg.org/#dom-createimagebitmap (see the SVG image element case there.) So, explicitly queuing a task to resolve a promise is required from a thread running in parallel? Or can I assume it's impliclity done?

Addressed the comment anyway (now it uses a normal task): 099deb9509eaf7348efb98ef6aaa6ac17d403d43

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/slightlyoff/ServiceWorker/issues/851#issuecomment-215281518

Received on Thursday, 28 April 2016 01:33:32 UTC