- From: Ben Kelly <notifications@github.com>
- Date: Mon, 25 Apr 2016 17:23:38 -0700
- To: slightlyoff/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc:
Received on Tuesday, 26 April 2016 00:24:11 UTC
@jungkees Overall these changes look great! I think in this case, though, we still need to fix up Install Algorithm step 14. As it stands now when you fire the state change event for 14.2 the registration.waiting attribute will still point to the worker being set to redundant. I think we either need to add a: > Run the Update Registration state algorithm passing registration, "waiting", and null as the arguments. Or remember the old waiting worker in a variable and then run Update Worker State after step 16. This would make the redundant worker state change event also see the new worker in the waiting spot. I think the second option here is slightly nicer for devs. Does that make sense? Thanks again! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/slightlyoff/ServiceWorker/issues/851#issuecomment-214570841
Received on Tuesday, 26 April 2016 00:24:11 UTC