Re: [streams] Byte stream update, including reference implementation (#361)

> +      CloseReadableByteStreamReader(this);
> +    }
> +  }
> +}
> +
> +function CallPull(controller) {
> +  const source = controller._underlyingByteSource;
> +
> +  const pullFunction = source['pull'];
> +  if (pullFunction === undefined) {
> +    return;
> +  }
> +
> +  const stream = controller._controlledReadableByteStream;
> +
> +  if (typeof pullFunction !== 'function') {

I just tried, but the exception it throws is "undefined is not a function" since it first evaluates pullFunction.apply (or pullFunction.call) and the result is undefined, and then undefined(source) is evaluated. So, it's not appropriate to set to storedError. I'd like to keep this. WDYT?

---
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/361/files#r33653828

Received on Wednesday, 1 July 2015 07:18:50 UTC