Re: [streams] Byte stream update, including reference implementation (#361)

> +      DetachReadableByteStreamReader(reader);
> +
> +      return;
> +    }
> +
> +    pullIntoDescriptor.bytesFilled += bytesWritten;
> +
> +    if (pullIntoDescriptor.bytesFilled >= pullIntoDescriptor.elementSize) {
> +      this._pendingPullIntos.shift();
> +
> +      let remainder;
> +      if (pullIntoDescriptor.bytesFilled % pullIntoDescriptor.elementSize > 0) {
> +        remainder = buffer.slice(result.bytesUsed, pullIntoDescriptor.bytesFilled);
> +      }
> +
> +      RespondToReadIntoRequest(reader, pullIntoDescriptor.buffer, pullIntoDescriptor.bytesFilled);

This code is not tested and actually doesn't work. I've fixed it and made it tested by 28cbdc8bd875ce5a1800fa9a38e0e2178fef887c.

---
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/361/files#r33647510

Received on Wednesday, 1 July 2015 04:33:12 UTC