- From: Domenic Denicola <notifications@github.com>
- Date: Wed, 21 Jan 2015 17:40:37 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Message-ID: <whatwg/streams/pull/270@github.com>
(Sits on top of #265) As per #255, the example-reading experience currently sucks. I re-did the existing ones, moved them around, and added new ones. Hope you guys can take a look! Check it out at https://streams.spec.whatwg.org/branch-snapshots/examples/. In particular: - https://streams.spec.whatwg.org/branch-snapshots/examples/#rs - https://streams.spec.whatwg.org/branch-snapshots/examples/#rs-get-reader - https://streams.spec.whatwg.org/branch-snapshots/examples/#ws - https://streams.spec.whatwg.org/branch-snapshots/examples/#blqs-class - https://streams.spec.whatwg.org/branch-snapshots/examples/#cqs-class - https://streams.spec.whatwg.org/branch-snapshots/examples/#examples - https://streams.spec.whatwg.org/branch-snapshots/examples/#state-machines (mostly just moved, but has some new intro text too) Review comments greatly appreciated!! You can view, comment on, or merge this pull request online at: https://github.com/whatwg/streams/pull/270 -- Commit Summary -- * Call underlying source functions as methods * Call underlying sink functions as methods. * Add tests for the new source/sink error cases * Clean up some terminology in the model section * Redo readable and writable stream examples * Move state machine diagrams to the end of the spec * Add an example use of getReader() * Add examples of the queuing strategies * Add example of a { readable, writable } pair -- File Changes -- M index.bs (1191) M readable-stream.svg (16) M reference-implementation/lib/helpers.js (46) M reference-implementation/lib/readable-stream-abstract-ops.js (49) M reference-implementation/lib/readable-stream.js (35) M reference-implementation/lib/writable-stream.js (72) A reference-implementation/test/bad-underlying-sinks.js (314) A reference-implementation/test/bad-underlying-sources.js (239) M reference-implementation/test/readable-stream.js (31) M reference-implementation/test/writable-stream-abort.js (12) M reference-implementation/test/writable-stream.js (38) -- Patch Links -- https://github.com/whatwg/streams/pull/270.patch https://github.com/whatwg/streams/pull/270.diff --- Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/270
Received on Thursday, 22 January 2015 01:41:16 UTC