Re: [fullscreen] Requesting fullscreen on the current fullscreen element should be an error (#17)

> Step 7.5.2 of requestFullscreen() already says "If element is doc's fullscreen element, terminate these subsubsteps. Note: No need to notify observers when nothing has changed."

This seems to be something annevk forgot to move or remove after fixing #5 

> perhaps by broken fallback code that ends up calling both a prefixed and unprefixed API

I would say this is impossible, because calling a nonexist function in JS would always through a TypeError, which stops any further code to be executed. Thus it dosen't make sense to call different API functions sequentially.

But, yeah, it seems to make sense otherwise.

I was thinking about the original restriction that we would reject a fullscreen request when the target element is an ancestor of the current fullscreen element. As we have removed that restriction, it probably doesn't make much sense now to reject anything because of this kind of reasons.

---
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/issues/17#issuecomment-131729267

Received on Monday, 17 August 2015 08:30:10 UTC