- From: Martin Thomson <notifications@github.com>
- Date: Tue, 04 Aug 2015 14:42:31 -0700
- To: w3c/push-api <push-api@noreply.github.com>
Received on Tuesday, 4 August 2015 21:42:59 UTC
I've updated the PR, which I think is largely OK. @costinm: > getPublicKey ? Is the parameter optional ( since enum can have only one possible value anyways ) ? I don't see much advantage in making the parameter optional. On the syntactic noise vs. being specific debate I always fall in the latter camp. > Also it should document very clearly what's in the ArrayBuffer - the DER encoding ? And how do we expect apps to send it to the app server ? The specification describes the encoding that is expected: https://tools.ietf.org/html/draft-thomson-webpush-encryption-01#section-5 Apps should be able to use the serializer on `PushSubscription`, that is, `JSON.stringify`. The only question I have here is how `ArrayBuffer` attributes are handled. --- Reply to this email directly or view it on GitHub: https://github.com/w3c/push-api/pull/130#issuecomment-127770908
Received on Tuesday, 4 August 2015 21:42:59 UTC