- From: Domenic Denicola <notifications@github.com>
- Date: Mon, 08 Dec 2014 07:57:30 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Message-ID: <whatwg/streams/pull/250/c66136303@github.com>
The next line resolves startResult as a promise, so this is not correct. ________________________________ From: Xabier Rodríguez<mailto:notifications@github.com> Sent: 2014-12-08 10:49 To: whatwg/streams<mailto:streams@noreply.github.com> Subject: [streams] Fix ReadableStream constructor if not getting a promise as startResult (#250) In the examples we have cases where the result of invoking the start is undefined and we treat it as something acceptable, therefore the constructor should be prepared to operate in that case. I guess this should also apply to other cases, like the WritableStream constructor, cancel functions, etc. ________________________________ You can merge this Pull Request by running git pull https://github.com/calvaris/streams constructor Or view, comment on, or merge it at: https://github.com/whatwg/streams/pull/250 Commit Summary * Fix ReadableStream constructor if not getting a promise as startResult File Changes * M index.bs<https://github.com/whatwg/streams/pull/250/files#diff-0> (1) Patch Links: * https://github.com/whatwg/streams/pull/250.patch * https://github.com/whatwg/streams/pull/250.diff — Reply to this email directly or view it on GitHub<https://github.com/whatwg/streams/pull/250>. --- Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/250#issuecomment-66136303
Received on Monday, 8 December 2014 15:57:58 UTC