Re: [infra-tests] use context manager instead of prerun script (#5771) from Bob Holt on 2017-05-04 (public-web-platform-tests-notifications@w3.org from May 2017)

From: Bob Holt <web-platform-tests-notifications@w3.org>
Date: Thu, 04 May 2017 12:46:36 GMT
To: public-web-platform-tests-notifications@w3.org
Message-Id: <<web-platform-tests_issue_5771_1493901996669@w3.org>>

Review status: 8 of 9 files reviewed at latest revision, 3 unresolved discussions.

---

*[tools/wptrunner/wptrunner/browsers/sauce.py, line 169 at r2](https://reviewable.io:443/reviews/w3c/web-platform-tests/5771#-KjITF5gLqXtAFay_1PK:-KjIUWGTxb2_cIV_9j9X:b-mff07n) ([raw file](https://github.com/w3c/web-platform-tests/blob/6ecdaa1c05a81233bdf08aabc935f9f51c61100b/tools/wptrunner/wptrunner/browsers/sauce.py#L169)):*
<details><summary><i>Previously, jgraham wrote…</i></summary><blockquote>

`temp_path` seems to be undefined here always. Using `try/except` isn't great; it's better to check if the dir was actually created and then try to delete it (with `try/except` just catching the `OSError` for the directory not exisitng anymore.
</blockquote></details>

Done. Ah yeah, I forgot to replace that name with `tempfile.gettempdir()`, and of course ignoring all errors didn't cause it to break my build. Consider my wrist slapped.

---


*Comments from [Reviewable](https://reviewable.io:443/reviews/w3c/web-platform-tests/5771)*
<!-- Sent from Reviewable.io -->


View on GitHub: https://github.com/w3c/web-platform-tests/pull/5771#issuecomment-299174791

Received on Thursday, 4 May 2017 12:46:48 UTC