- From: Geoffrey Sneddon <web-platform-tests-notifications@w3.org>
- Date: Wed, 03 May 2017 17:00:29 GMT
- To: public-web-platform-tests-notifications@w3.org
@dholbert > Questions: > > *On reviewing in general*: > > 1. What's the recommended UI for leaving review comments on lines of code at this point? The "Reviewable" button at the top of this review request seems to take me to the wrong page, since it says "branch abandoned" at the top right. As I mentioned on IRC yesterday: the Reviewable link is that from the old csswg-test repo, so that's broken on the PRs imported from there. > 2. Is there a better way for me to actually get the files (and their resources) locally, aside from copypasting IDs into the "Modifying an inactive pull request locally" longform steps at [this help page](https://help.github.com/articles/checking-out-pull-requests-locally/)? (That page's initial "modifying an active pull request locally" section says I *should* see a "command line instructions" button on this pull-request page somewhere, but that's not there for me. I think maybe GitHub only shows that to people who have merge privileges? I don't want to have merge privileges, but I would like to be able to view files that I'm reviewing locally.) Yeah, looking around, I think you need merge permissions… That's a nice bug in the docs. I always just go for `git fetch origin pull/ID/head && git checkout FETCH_HEAD`, which is the steps for inactive PRs. There's also http://w3c-test.org/submissions/ which contains mirrored copies of PRs if you just want to run them. View on GitHub: https://github.com/w3c/web-platform-tests/pull/5281#issuecomment-298972187
Received on Wednesday, 3 May 2017 17:00:41 UTC