- From: Domenic Denicola <web-platform-tests-notifications@w3.org>
- Date: Mon, 06 Mar 2017 20:26:03 GMT
- To: public-web-platform-tests-notifications@w3.org
I still think the lines like ```diff + /** + * Tests for creating a new browsing context, [Browsing Contexts](#windows) + */ ``` are a bit unnecessary. We already know we're testing that section of the spec via the filename. And it's using some Markdown syntax which doesn't appear to have any effect (assuming it's intended to be Markdown; the link doesn't go anywhere within that file). And it's using a three-line comment where a one-line comment would do. (Also, in general the use of multiline comments is weird here, because you end up just prefixing every line with `*` anyway. Better to prefix with `//`, and then you can avoid the extra `/**` and `*/` lines.) Otherwise though things seem pretty good. The rest of the comments are fine to keep I guess, if they're helpful to you. As you said I'm sure you'll find a good equilibrium over time. As long as they're not redundant with the assertion messages and filenames and `<title>`s and such, I'm happy. View on GitHub: https://github.com/w3c/web-platform-tests/pull/5040#issuecomment-284521245
Received on Monday, 6 March 2017 20:26:15 UTC