- From: Simon Pieters <web-platform-tests-notifications@w3.org>
- Date: Tue, 07 Mar 2017 05:43:38 GMT
- To: public-web-platform-tests-notifications@w3.org
The problem usually with repeating what is asserted in comments (and even in the message argument to `assert_*`) is that somebody fixes a test because the standard had changed, and only updates the actual assertion and forgets to update the comment and assertion message. Then the test is even more confusing. (If the comment is "far away" from the actual assertion, this is likely to be missed in review as well because the diff shows just a few lines of context and there's little incentive for reviewers to check whole files for every change.) View on GitHub: https://github.com/w3c/web-platform-tests/pull/5040#issuecomment-284627759
Received on Tuesday, 7 March 2017 05:43:51 UTC