Re: [html-tests] Test cleanup, coverage improvement, HTML 7.1 Browsing Context (#5040)

@domenic Thanks! I really appreciate the follow-up. It can be hard to be a new contributor and gain confidence in "the ropes." It made a big difference.

I've pushed some commits that address two main areas of feedback:

1. I agree with y'all that the `--` filenames were nope nope nope. Thanks to @annevk for reminding me of the `resources` subdir convention—I've gone that direction. It's refreshing getting those supporting files out of the "main" directory, and easier to scan now, I think.
2. Last week when I started in on this section, I kept thinking how much easier it would be to draw connections between things and find gaps if there were a touch more commenting. That viewpoint is countered by you more-seasoned folks' assertion that the tests are more self-documenting than I immediately grasped. I tried to address this by dialing back the comments a smidge...making them less verbatim and a little looser. But I'm hesitant to ditch all of them in that I feel like they would have been helpful to _me_ (past self). Put another way, are they going to cause harm or future angst in their current state? If so, I can trim more. Of course, my perspective on all of this may change markedly over the next few weeks!

View on GitHub: https://github.com/w3c/web-platform-tests/pull/5040#issuecomment-284475382

Received on Monday, 6 March 2017 17:50:32 UTC