Re: [paint-timing]

Ah, nice. Looks good, merged. Thanks Nicolas!

On Tue, Aug 21, 2018 at 9:41 AM Nicolás Peña <npm@google.com> wrote:

> I've added this fix to https://github.com/w3c/paint-timing/pull/27 which
> I had forgotten about.
>
> On Tue, Aug 21, 2018 at 12:15 PM Ilya Grigorik <igrigorik@google.com>
> wrote:
>
>> Ah, nice catch! Thanks for reporting this.
>>
>> +Shubhie Panicker <panicker@google.com> fyi, a quick fix? :-)
>>
>> On Tue, Aug 21, 2018 at 4:22 AM 刘博文 <liubowen@360.cn> wrote:
>>
>>> Hello Everyone.
>>>
>>> in the https://w3c.github.io/paint-timing/ draft , I found an error.
>>>
>>> In the 1.1. Usage example section, The last line of comment code is
>>> wrong.
>>>
>>> var observer = new PerformanceObserver(function(list) {
>>>     var perfEntries = list.getEntries();
>>>     for (var i = 0; i < perfEntries.length; i++) {
>>>         // Process entries        // report back for analytics and monitoring        // ...    }});
>>> // register observer for long task notificationsobserver.observe({entryTypes: ["paint"]});
>>>
>>>
>>> The comment code should be changed to the following:
>>>
>>> var observer = new PerformanceObserver(function(list) {
>>>     var perfEntries = list.getEntries();
>>>     for (var i = 0; i < perfEntries.length; i++) {
>>>         // Process entries        // report back for analytics and monitoring        // ...    }});
>>> // register observer for paint timing notificationsobserver.observe({entryTypes: ["paint"]});
>>>
>>>
>>>