- From: Karen Anderson (IE) <Karen.Anderson@microsoft.com>
- Date: Thu, 14 Apr 2011 17:08:09 +0000
- To: Nic Jansma <Nic.Jansma@microsoft.com>, Tony Gentilcore <tonyg@google.com>
- CC: Zhiheng Wang <zhihengw@google.com>, James Simonsen <simonjam@chromium.org>, "public-web-perf@w3.org" <public-web-perf@w3.org>
- Message-ID: <34353495FD395C45833D25DEDFB9DD381FBBF0D3@TK5EX14MBXC132.redmond.corp.microsoft.>
Yes, good catch. Oddly, in my local testing I have both test_greater_than and test_greater_than_equals, to cover this. For this test, yes we want test_greater_than, though for the timing order test we really want test_greater_than_equals. I have a change for the early bail out scenario we've been talking about that I am going to review with Nic this week. Perhaps we can the new assert function within this submit. Thanks, Karen From: public-web-perf-request@w3.org [mailto:public-web-perf-request@w3.org] On Behalf Of Nic Jansma Sent: Wednesday, April 13, 2011 2:25 PM To: Tony Gentilcore Cc: Zhiheng Wang; James Simonsen; public-web-perf@w3.org Subject: RE: [minutes] 20110406 Web Performance WG Teleconference #27 Yes, we will hold off on this until we've settled on the navigationStart issues and we've added the domain validation. - Nic From: Tony Gentilcore [mailto:tonyg@google.com] Sent: Wednesday, April 13, 2011 1:10 PM To: Nic Jansma Cc: Zhiheng Wang; James Simonsen; public-web-perf@w3.org Subject: Re: [minutes] 20110406 Web Performance WG Teleconference #27 This validates that navigationStart is 0 after a cross-origin redirect. Should we hold off on approving until we figure out that issue? On Wed, Apr 13, 2011 at 12:39 PM, Nic Jansma <Nic.Jansma@microsoft.com<mailto:Nic.Jansma@microsoft.com>> wrote: Yep, Karen is preparing some updates to validate the starting domain. - Nic From: Zhiheng Wang [mailto:zhihengw@google.com<mailto:zhihengw@google.com>] Sent: Wednesday, April 13, 2011 12:00 PM To: James Simonsen Cc: Nic Jansma; public-web-perf@w3.org<mailto:public-web-perf@w3.org> Subject: Re: [minutes] 20110406 Web Performance WG Teleconference #27 The X-origin redirect test<http://w3c-test.org/webperf/tests/submission/Microsoft/NavigationTiming/test_timing_xserver_redirect.htm> works fine on http://w3c-test.org but not http://www.w3c-test.org since the iframe destination is set to w3c-test.org<http://w3c-test.org>. Shall we check the root document host name and set it in the redirect? cheers, Zhiheng On Wed, Apr 13, 2011 at 11:29 AM, James Simonsen <simonjam@chromium.org<mailto:simonjam@chromium.org>> wrote: The new tests look good to me. Thanks! James On Wed, Apr 13, 2011 at 11:22 AM, Nic Jansma <Nic.Jansma@microsoft.com<mailto:Nic.Jansma@microsoft.com>> wrote: Great catch! I updated test_timing_greater_than() to actually only test >, which is what we want. We don't have anything actually testing >=. - Nic From: simonjam@google.com<mailto:simonjam@google.com> [mailto:simonjam@google.com<mailto:simonjam@google.com>] On Behalf Of James Simonsen Sent: Wednesday, April 13, 2011 11:12 AM To: Nic Jansma Cc: public-web-perf@w3.org<mailto:public-web-perf@w3.org> Subject: Re: [minutes] 20110406 Web Performance WG Teleconference #27 On Wed, Apr 13, 2011 at 10:50 AM, Nic Jansma <Nic.Jansma@microsoft.com<mailto:Nic.Jansma@microsoft.com>> wrote: http://w3c-test.org/webperf/tests/submission/Microsoft/NavigationTiming/test_timing_server_redirect.htm test_timing_greater_than('navigationStart', 0); Despite its name, this is actually testing >=, so we're in the same boat if navigationStart is 0. I'd suggest renaming the helper function too, to better reflect what it's doing. James
Received on Friday, 15 April 2011 10:21:57 UTC