- From: François Beaufort via GitHub <sysbot+gh@w3.org>
- Date: Mon, 23 Dec 2019 08:31:46 +0000
- To: public-web-nfc@w3.org
> This still doesn't seem right, at least based on something that would make the examples work. Having "resolve p" as step 7 makes it sound like the promise doesn't get resolved until after the browser _stops_ trying to detect NFC technology. I suspect the intent is to resolve the promise after "4. Add reader to the activated reader objects.", although it's possible that it could be right before (4) as well (which would be detectably different). I should have resolved |p| earlier to make it clear indeed. I've opened https://github.com/w3c/web-nfc/pull/483 to fix it. > (I'd also note that (2) and (3) don't really seem like separate steps. But it also seems like, implicitly, between them, there's something like "wait for this request to ???", so that they could be combined as something like: " If this is the first listener being set up, then make a request to all NFC adapters to listen to NDEF messages. Wait for this request to ???. If the request fails, then the UA MAY reject p with a "NotSupportedError" DOMException and abort these steps." (Though this also seems to forbid a UA from trying again if it fails once, which might be undesirable.) @zolkis @kenchris I'm not sure what "make a request to all NFC adapters to listen to NDEF messages." means? Is this a concept from the previous spec version? We're already checking if no underlying NFC Adapter, if a connection cannot be established, and if the UA is not allowed to access the underlying NFC Adapter (e.g. a user preference) earlier, so I'm not sure what this refers to?  > Likewise, it's not clear to me that step 5, currently: > > > If the Document of the top-level browsing context is not visible (e.g. the user navigated to another page), then the registered activated reader objects still SHOULD continue to exist, but SHOULD become paused, i.e. the UA SHOULD NOT check and use them until the Document is visible again. > > is really a step that happens chronologically. As we already have https://w3c.github.io/web-nfc/#handling-visibility-change, we may want to remove step 5 here. What do you think @kenchris @zolkis? -- GitHub Notification of comment by beaufortfrancois Please view or discuss this issue at https://github.com/w3c/web-nfc/issues/478#issuecomment-568401815 using your GitHub account
Received on Monday, 23 December 2019 08:31:48 UTC