- From: Vincent Scheib via GitHub <sysbot+gh@w3.org>
- Date: Sun, 04 Sep 2016 19:41:05 +0000
- To: public-web-bluetooth-log@w3.org
I see that this is also specifying that disconnect will not sever other connections on the system. E.g. if 2 Android apps are using a connection to a peripheral and one of them is a Web Bluetooth browser, then calling disconnect there will not disconnect the central from the peripheral. Sounds good to me, but worth perhaps calling that out in the change description as well. Overall LGTM On Wed, Aug 31, 2016 at 3:37 PM, Jeffrey Yasskin <notifications@github.com> wrote: > Also add a note that connect() could wait forever if an appropriate > advertisement isn't received. > > Fixes #152 <https://github.com/WebBluetoothCG/web-bluetooth/issues/152>. > > Preview at https://api.csswg.org/bikeshed/?url=https://raw.githubuserco > ntent.com/jyasskin/web-bluetooth-1/hanging-connect/ > index.bs#dom-bluetoothremotegattserver-connect. > ------------------------------ > You can view, comment on, or merge this pull request online at: > > https://github.com/WebBluetoothCG/web-bluetooth/pull/280 > Commit Summary > > - Make disconnect() abort connect(). > > File Changes > > - *M* index.bs > <https://github.com/WebBluetoothCG/web-bluetooth/pull/280/files#diff-0> > (122) > > Patch Links: > > - https://github.com/WebBluetoothCG/web-bluetooth/pull/280.patch > - https://github.com/WebBluetoothCG/web-bluetooth/pull/280.diff > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/WebBluetoothCG/web-bluetooth/pull/280>, or mute the > thread > <https://github.com/notifications/unsubscribe-auth/AAXnm9kD-SG_ntucFJTa1QOYEPk-6Zptks5qlgI5gaJpZM4JyI00> > . > -- GitHub Notification of comment by scheib Please view or discuss this issue at https://github.com/WebBluetoothCG/web-bluetooth/pull/280#issuecomment-244624317 using your GitHub account
Received on Sunday, 4 September 2016 19:41:13 UTC