- From: Jeffrey Yasskin via GitHub <sysbot+gh@w3.org>
- Date: Mon, 18 May 2015 18:00:25 +0000
- To: public-web-bluetooth-log@w3.org
> I think you intend to append to 'filters' not 'filter'. Rename 'filters' to a) make it more distinct and not confused with filter/options.filters and b) indicate intent that it has the translated service names/aliases. > Maybe parsed_filters? > > Or, (possibly non-normative) comments highlighting what a block like this is trying to do. "Interpret all services in filter from names or aliases", something like that. I did both: https://github.com/WebBluetoothCG/web-bluetooth/pull/112/files#diff-eacf331f0ffc35d4b482f1d15a887d3bR434 > May wish to support UUID aliases as well as full UUIDs here? So that for API points accepting BluetoothServiceUUID developers can just enter the 0x1234 alias? e.g. allow all these: > server.getPrimaryService(0x1801) > server.getPrimaryService(00001801-0000-1000-8000-00805f9b34fb) > server.getPrimaryService("cycling_power") Yeah, makes sense. Done: https://github.com/WebBluetoothCG/web-bluetooth/pull/112/files#diff-eacf331f0ffc35d4b482f1d15a887d3bR2572 -- GitHub Notif of comment by jyasskin See https://github.com/WebBluetoothCG/web-bluetooth/pull/112#issuecomment-103149615
Received on Monday, 18 May 2015 18:00:26 UTC