- From: Vincent Scheib via GitHub <sysbot+gh@w3.org>
- Date: Sat, 16 May 2015 22:00:38 +0000
- To: public-web-bluetooth-log@w3.org
Review status: all files reviewed, 2 unresolved discussions, all
commit checks successful.
Reviewed files:
- index.html @ r1
---
<sup>**[index.html, line 449
\[r1\]](https://reviewable.io:443/reviews/webbluetoothcg/web-bluetooth/112#-JpTRygAX5XkQ8vcu4dF)**
([raw
file](https://github.com/webbluetoothcg/web-bluetooth/blob/1ae9775db87ce9910c09964690310d17249af985/index.html#L449)):</sup>
I think you intend to append to 'filters' not 'filter'. Rename
'filters' to a) make it more distinct and not confused with
filter/options.filters and b) indicate intent that it has the
translated service names/aliases.
Maybe parsed_filters?
Or, (possibly non-normative) comments highlighting what a block like
this is trying to do. "Interpret all services in filter from names or
aliases", something like that.
---
<sup>**[index.html, line 2564
\[r1\]](https://reviewable.io:443/reviews/webbluetoothcg/web-bluetooth/112#-JpTfvZE8HQ0qdg4OCft)**
([raw
file](https://github.com/webbluetoothcg/web-bluetooth/blob/1ae9775db87ce9910c09964690310d17249af985/index.html#L2564)):</sup>
May wish to support UUID aliases as well as full UUIDs here? So that
for API points accepting BluetoothServiceUUID developers can just
enter the 0x1234 alias? e.g. allow all these:
server.getPrimaryService(0x1801)
server.getPrimaryService(00001801-0000-1000-8000-00805f9b34fb)
server.getPrimaryService("cycling_power")
---
Comments from the [review on
Reviewable.io](https://reviewable.io:443/reviews/webbluetoothcg/web-bluetooth/112)
<!-- Sent from Reviewable.io -->
--
GitHub Notif of comment by scheib
See
https://github.com/WebBluetoothCG/web-bluetooth/pull/112#issuecomment-102703154
Received on Saturday, 16 May 2015 22:00:40 UTC