W3C home > Mailing lists > Public > public-web-bluetooth-log@w3.org > April 2015

Re: [web-bluetooth] Move requestDevice()'s filters argument into its options dictionary.

From: Vincent Scheib via GitHub <sysbot+gh@w3.org>
Date: Thu, 23 Apr 2015 23:08:58 +0000
To: public-web-bluetooth-log@w3.org
Message-ID: <issue_comment.created-95743376-1429830538-sysbot+gh@w3.org>
LGTM. I support the change. I think most uses cases we anticipate 
early will be just a single filter set, so it's a bit verbose for 
those, but it is clearer as soon as more are added or options ones 
are. And, it of course enables future expansion cleanly.

---

Reviewed files:
- index.html @ r1

---

<sup>**[index.html, line 317 
\[r1\]](https://reviewable.io:443/reviews/webbluetoothcg/web-bluetooth/107#-JncVSHcc0hEqs634cAC)**
 ([raw 
file](https://github.com/webbluetoothcg/web-bluetooth/blob/95086e64f5b0d92695df40c2095c212b017b12d9/index.html#L317)):</sup>
Single line this now.

---


---

Comments from the [review on 
Reviewable.io](https://reviewable.io:443/reviews/webbluetoothcg/web-bluetooth/107)
<!-- Sent from Reviewable.io -->


-- 
GitHub Notif of comment by scheib
See 
https://github.com/WebBluetoothCG/web-bluetooth/pull/107#issuecomment-95743376
Received on Thursday, 23 April 2015 23:08:59 UTC

This archive was generated by hypermail 2.3.1 : Thursday, 23 April 2015 23:09:00 UTC