W3C home > Mailing lists > Public > public-web-bluetooth-log@w3.org > April 2015

Re: [web-bluetooth] Add an example of using advertising data to read an iBeacon.

From: Vincent Scheib via GitHub <sysbot+gh@w3.org>
Date: Fri, 03 Apr 2015 17:49:08 +0000
To: public-web-bluetooth-log@w3.org
Message-ID: <issue_comment.created-89373729-1428083347-sysbot+gh@w3.org>
LGTM with some suggestions. 

---

Reviewed files:
- index.html @ r1

---

<sup>**[index.html, line 979 
\[r1\]](https://reviewable.io:443/reviews/webbluetoothcg/web-bluetooth/97#-Jm-LqQgJwIHbcp5d3Mg)**
 ([raw 
file](https://github.com/webbluetoothcg/web-bluetooth/blob/0aae0472a57befc5cebbeafe07d3587cc6185d65/index.html#L979)):</sup>
The spec flow is a bit abrupt with the current location. Either, add a
 short intro section for 4.3.3 that orients the reader to the section,
 and offer the example; or move the example to the end of the 4.3.3 
section (after 4.3.3.1 if possible).

---

<sup>**[index.html, line 991 
\[r1\]](https://reviewable.io:443/reviews/webbluetoothcg/web-bluetooth/97#-Jm-MVN3mcD3pvBRaIRR)**
 ([raw 
file](https://github.com/webbluetoothcg/web-bluetooth/blob/0aae0472a57befc5cebbeafe07d3587cc6185d65/index.html#L991)):</sup>
This and the other numbers would benefit from a link to the spec of 
the iBeacon manufacturer data. After a few minutes of searching I 
didn't find one, so if the source you used is appropriate it would 
have good value being referenced.

---


---

Comments from the [review on 
Reviewable.io](https://reviewable.io:443/reviews/webbluetoothcg/web-bluetooth/97)
<!-- Sent from Reviewable.io -->


-- 
GitHub Notif of comment by scheib
See 
https://github.com/WebBluetoothCG/web-bluetooth/pull/97#issuecomment-89373729
Received on Friday, 3 April 2015 17:49:16 UTC

This archive was generated by hypermail 2.3.1 : Friday, 3 April 2015 17:49:17 UTC