W3C home > Mailing lists > Public > public-test-infra@w3.org > January to March 2017

Re: csswg-test merge into web-platform-tests

From: Florian Rivoal <florian@rivoal.net>
Date: Mon, 27 Mar 2017 15:20:26 +0900
Cc: www-style list <www-style@w3.org>, "public-css-testsuite@w3.org" <public-css-testsuite@w3.org>, public-test-infra <public-test-infra@w3.org>, James Graham <james@hoppipolla.co.uk>, John Jansen <John.Jansen@microsoft.com>, Greg Whitworth <gwhit@microsoft.com>, Quinten Yearsley <qyearsley@chromium.org>, Koji Ishii <kojii@chromium.org>, youenn@apple.com, Peter Linss <peter@linss.com>, Philip Jägenstedt <foolip@chromium.org>, Benjamin De Cock <ben@stripe.com>
Message-Id: <6F7FF797-C9FB-4D45-89E1-DD4AA6BF032C@rivoal.net>
To: Geoffrey Sneddon <me@gsnedders.com>

> On Mar 25, 2017, at 01:22, Geoffrey Sneddon <me@gsnedders.com> wrote:
> PRs that would be a pain for me to move over are those with any
> reviews/comments on actual commits (as opposed to the PR itself).
> Notably:
> * https://github.com/w3c/csswg-test/pull/1192

This is my PR, and I'm still waiting for review (Thousands of thanks to Fantasai for reviewing the rest of my CSS-UI PRs).

This one is unfortunately somewhat tricky: as the outline properties it tests are full of undefined behavior, the tests are somewhat convoluted in order to actually hit testable assertions without depending on undefined behavior.

Still, I'd love for someone to give a shot at reviewing them. I'll be happy to fix anything that's wrong (or unnecessary), and to document anything that's necessary but hard to grok.

> [...]

Received on Monday, 27 March 2017 06:21:01 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 17:34:13 UTC