W3C home > Mailing lists > Public > public-test-infra@w3.org > October to December 2016

Re: [ACTION REQUIRED] Re: Stability testing of PRs

From: David Dorwin <ddorwin@google.com>
Date: Sat, 22 Oct 2016 19:18:24 -0700
Message-ID: <CAHD2rsiXmkkUUPAKYGju2tK-XpR8QeTwfvtSVTB_Do05VdGRMw@mail.gmail.com>
To: Shane McCarron <shane@spec-ops.io>
Cc: James Graham <james@hoppipolla.co.uk>, public-test-infra <public-test-infra@w3.org>
Is that what is causing the "CRITICAL:check_stability:Must provide a GitHub
token via --gh-token or $GITHUB_TOKEN" errors as in
https://travis-ci.org/w3c/web-platform-tests/jobs/169632215?

Can we disable these checks until there is a solution?

On Sat, Oct 22, 2016 at 2:20 PM, Shane McCarron <shane@spec-ops.io> wrote:

> Oh dear.   I didn't know about that restriction.
>
> Aren't most submitters working from forks?  And shouldn't they be?
>
> On Sat, Oct 22, 2016 at 4:16 PM, James Graham <james@hoppipolla.co.uk>
> wrote:
>
>> On 22/10/16 10:41, James Graham wrote:
>>
>> The script was failing for some reason on a number of PRs (invalid
>>> responses from GitHub, mostly). I've just pushed a commit that moves
>>> most of the logic into python which I hope will be more robust, or at
>>> least easier to debug if things go wrong.
>>>
>>> Please rebase your failing PRs on to master so that they run with the
>>> latest changes.
>>>
>>
>> OK, this is still a little broken. I had forgotten that for rather
>> obvious security reasons, travis doesn't share encrypted environment
>> variables with PRs from forks. I'll try to think of a solution for this
>> that doesn't make the experience for submitters working in forks too
>> terrible.
>>
>>
>>
>
>
> --
> Shane McCarron
> Projects Manager, Spec-Ops
>
Received on Sunday, 23 October 2016 02:19:13 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 17:34:12 UTC