W3C home > Mailing lists > Public > public-test-infra@w3.org > October to December 2014

Re: Git question on reviewing tests and contributing fixes

From: Andreas Tolfsen <ato@mozilla.com>
Date: Tue, 16 Dec 2014 14:07:57 +0000
Message-ID: <CAL_dnaVt7S6arKuFLyS2v5+NGE8n+jeKs2dUXnXFL6vSX1t9Dw@mail.gmail.com>
To: Brad Hill <hillbrad@gmail.com>
Cc: public-test-infra <public-test-infra@w3.org>
On Tue, Dec 16, 2014 at 1:49 AM, Brad Hill <hillbrad@gmail.com> wrote:
> Really, I have the time right now and I'd like to just make the edits and
> send bob a PR to fix them.  Especially for getting new contributors up to
> speed, I think this is important encouragement.

I quite like working in this way.  Given a mutual understanding
between the people working on that branch, it helps PRs move along
quicker and allows people to work together.

> I also tried from the Github web UI to fork bob's fork, but that doesn't
> seem to work either.

critic tracks a single remote, and forking Bob's repository will
create a new remote.

> Is there any way to do this?  Does bob have to add me as a collaborator on
> his fork?

This is a limitation Github imposes, and Bob will have to add you as a
collaborator on his repository.

I think the current suggestion is to drop Bob's original review and
submit a new one under your name, which admittedly isn't great.
Received on Tuesday, 16 December 2014 14:08:26 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 17:34:11 UTC